all good v2

Reviewed-on: #25

.gitea/workflows/deploy.yml

@@ -46,7 +46,6 @@ jobs:
             -Dsonar.javascript.lcov.reportPaths=coverage/lcov.info
 
       - name: 5. Dynamic Security Scan (OWASP ZAP)
-        # REMOVIDO o "if: github.event_name == 'push'". Agora o ZAP corre SEMPRE (nos PRs e nos Merges)!
         run: |
           echo ">>> 1. Limpeza profunda do ambiente..."
           docker rm -f apex-sandbox zap-scanner || true
@@ -96,17 +95,7 @@ jobs:
             exit 0
           fi
 
-      - name: 6.1. Enviar Relatório ZAP para o Servidor (SCP)
-        if: github.event_name == 'push'
-        uses: appleboy/scp-action@master
-        with:
-          host: ${{ secrets.SSH_HOST }}
-          username: ${{ secrets.SSH_USER }}
-          key: ${{ secrets.SSH_PRIVATE_KEY }}
-          source: "qatests/report.html"
-          target: "/tmp"
-
-      - name: 6.2. Deploy em Produção (SSH)
+      - name: 6. Deploy em Produção (SSH)
         if: github.event_name == 'push'
         uses: appleboy/ssh-action@master
         with:
@@ -114,6 +103,8 @@ jobs:
           username: ${{ secrets.SSH_USER }}
           key: ${{ secrets.SSH_PRIVATE_KEY }}
           script: |
+            set -e 
+            
             echo ">>> 1. A navegar para a pasta do projeto no servidor..."
             cd /storage/docker/website-secure
             
@@ -121,18 +112,12 @@ jobs:
             git pull origin main
             
             echo ">>> 3. A compilar a imagem Docker de Produção..."
-            # Compilamos a imagem com a tag :prod para ficar bem identificada
             docker build -f backend/Dockerfile -t apex-solutions:prod .
             
             echo ">>> 4. A substituir o contentor em execução..."
-            # Removemos o contentor antigo e subimos o novo na porta 3000
             docker rm -f portal-corporativo || true
             docker run -d -p 3000:3000 --name portal-corporativo --restart unless-stopped apex-solutions:prod
             
-            echo ">>> 5. A publicar o relatório de segurança transparente..."
-            sleep 5
-            docker cp /tmp/qatests/report.html portal-corporativo:/usr/src/app/frontend/zap-report.html || true
-            
             echo "✅ Deploy concluído com sucesso! A aplicação está no ar."
 
       - name: 7. Archive ZAP Report

backend/server.js

@@ -13,31 +13,18 @@ app.use(cors());
 app.use(express.json());
 app.use(express.urlencoded({ extended: true }));
 
+
+
 // Serve a pasta frontend
 app.use(express.static(path.join(__dirname, '../frontend'), { extensions: ['html'] }));
 
-// Rotas das 4 páginas estáticas
-app.get('/', (req, res) => res.sendFile(path.join(__dirname, '../frontend/index.html')));
+// Rotas das páginas estáticas (A rota '/' original foi comentada para não dar conflito com a do ZAP)
+// app.get('/', (req, res) => res.sendFile(path.join(__dirname, '../frontend/index.html'))); 
 app.get('/about', (req, res) => res.sendFile(path.join(__dirname, '../frontend/about.html')));
 app.get('/careers', (req, res) => res.sendFile(path.join(__dirname, '../frontend/careers.html')));
 app.get('/contact', (req, res) => res.sendFile(path.join(__dirname, '../frontend/contact.html')));
 
-// ==========================================
-// VULNERÁVEL (OWASP ZAP)
-// ==========================================
-/*app.get('/api/search', (req, res) => {
-    const termo = req.query.q || '';
-    // A vulnerabilidade crítica: devolver o input diretamente no HTML
-    res.send(`
-        <html>
-            <head><title>Resultados</title></head>
-            <body>
-                <h1>Resultados para: ${termo}</h1>
-                <a href="/">Voltar</a>
-            </body>
-        </html>
-    `);
-});*/
+// O eval() FOI REMOVIDO DAQUI PARA O SONARQUBE NÃO BLOQUEAR!
 
 // Configuração do transporte de E-mail (Mocks de teste vs Produção)
 let transporter;

frontend/index.html

@@ -33,7 +33,7 @@
             <div class="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8 py-24 lg:py-32">
                 <h1 class="text-4xl tracking-tight font-extrabold text-gray-900 sm:text-5xl md:text-6xl">
                     <span class="block">Innovative Solutions for</span>
-                    <span class="block text-blue-600">Modern Busines - Test CI/CD</span>
+                    <span class="block text-blue-600">Modern website-secure</span>
                 </h1>
                 <p class="mt-6 max-w-2xl text-lg text-gray-500 leading-relaxed">
                     At Apex Solutions, we deliver high-quality business consulting, technology services, and strategic insights. We help organizations across the globe achieve their goals through operational excellence and digital transformation.

package-lock.json

@@ -11,7 +11,6 @@
       "dependencies": {
         "cors": "^2.8.5",
         "express": "^4.18.2",
-        "lodash": "4.17.15",
         "nodemailer": "^8.0.11"
       },
       "devDependencies": {
@@ -1308,9 +1307,6 @@
         "arm64"
       ],
       "dev": true,
-      "libc": [
-        "glibc"
-      ],
       "license": "MIT",
       "optional": true,
       "os": [
@@ -1325,9 +1321,6 @@
         "arm64"
       ],
       "dev": true,
-      "libc": [
-        "musl"
-      ],
       "license": "MIT",
       "optional": true,
       "os": [
@@ -1342,9 +1335,6 @@
         "loong64"
       ],
       "dev": true,
-      "libc": [
-        "glibc"
-      ],
       "license": "MIT",
       "optional": true,
       "os": [
@@ -1359,9 +1349,6 @@
         "loong64"
       ],
       "dev": true,
-      "libc": [
-        "musl"
-      ],
       "license": "MIT",
       "optional": true,
       "os": [
@@ -1376,9 +1363,6 @@
         "ppc64"
       ],
       "dev": true,
-      "libc": [
-        "glibc"
-      ],
       "license": "MIT",
       "optional": true,
       "os": [
@@ -1393,9 +1377,6 @@
         "riscv64"
       ],
       "dev": true,
-      "libc": [
-        "glibc"
-      ],
       "license": "MIT",
       "optional": true,
       "os": [
@@ -1410,9 +1391,6 @@
         "riscv64"
       ],
       "dev": true,
-      "libc": [
-        "musl"
-      ],
       "license": "MIT",
       "optional": true,
       "os": [
@@ -1427,9 +1405,6 @@
         "s390x"
       ],
       "dev": true,
-      "libc": [
-        "glibc"
-      ],
       "license": "MIT",
       "optional": true,
       "os": [
@@ -1444,9 +1419,6 @@
         "x64"
       ],
       "dev": true,
-      "libc": [
-        "glibc"
-      ],
       "license": "MIT",
       "optional": true,
       "os": [
@@ -1461,9 +1433,6 @@
         "x64"
       ],
       "dev": true,
-      "libc": [
-        "musl"
-      ],
       "license": "MIT",
       "optional": true,
       "os": [
@@ -3900,12 +3869,6 @@
         "node": ">=8"
       }
     },
-    "node_modules/lodash": {
-      "version": "4.17.15",
-      "resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.15.tgz",
-      "integrity": "sha512-8xOcRHvCjnocdS5cpwXQXVzmmh5e5+saE2QGoeQmbKmRS6J3VQppPOIt0MnmE+4xlZoumy0GPG0D0MVIQbNA1A==",
-      "license": "MIT"
-    },
     "node_modules/lru-cache": {
       "version": "5.1.1",
       "resolved": "https://registry.npmjs.org/lru-cache/-/lru-cache-5.1.1.tgz",

package.json

@@ -18,6 +18,7 @@
     "cors": "^2.8.5",
     "express": "^4.18.2",
     "nodemailer": "^8.0.11"
+
   },
   "devDependencies": {
     "jest": "^30.4.2",

tests/core.test.js

@@ -36,15 +36,6 @@ describe('Enterprise Application Flow & API Validation', () => {
             expect(response.status).toBe(404);
         });
 
-        /*//  OWASP ZAP (/api/search)
-        it('Should reflect the search query in the HTML response (/api/search) - Vulnerable to XSS', async () => {
-            const maliciousPayload = '<script>alert("ZAP")</script>';
-            const response = await request(app).get(`/api/search?q=${maliciousPayload}`);
-            
-            expect(response.status).toBe(200);
-            // Verifica se o payload é refletido exatamente como entrou (confirmando a vulnerabilidade)
-            expect(response.text).toContain(`Resultados para: ${maliciousPayload}`);
-        });*/
     });
 
     // ==========================================