From c63239e7ee68b23eaee0eb4119878b1e4733f229 Mon Sep 17 00:00:00 2001
From: pedro <pedro.maio@each-cs.com>
Date: Tue, 16 Jun 2026 16:02:41 +0100
Subject: [PATCH] OWASP ZAP Validation

---
 backend/server.js | 70 +++++++++++++++++++++--------------------------
 1 file changed, 31 insertions(+), 39 deletions(-)

diff --git a/backend/server.js b/backend/server.js
index 44614dd..0210e66 100644
--- a/backend/server.js
+++ b/backend/server.js
@@ -13,26 +13,39 @@ app.use(cors());
 app.use(express.json());
 app.use(express.urlencoded({ extended: true }));
 
+// ==========================================
+// ROTA LIMPA (Passa no SonarQube, chumba no ZAP)
+// ==========================================
+
+// Modificamos a rota principal temporariamente para o ZAP encontrar o link
+app.get('/', (req, res) => {
+    res.send(`
+        <html>
+            <body>
+                <h1>Bem-vindo a Apex Solutions</h1>
+                <!-- O ZAP vai encontrar este link, clicar nele e tentar injetar código -->
+                <a href="/api/search?q=teste">Pesquisar</a>
+            </body>
+        </html>
+    `);
+});
+
+// A rota vulnerável a XSS que o SonarQube ignora (por ser versão gratuita)
+app.get('/api/search', (req, res) => {
+    const termo = req.query.q || '';
+    // Vulnerabilidade Crítica: XSS Refletido
+    res.send(`<html><body><h1>Resultados para: ${termo}</h1></body></html>`);
+});
+
 // Serve a pasta frontend
 app.use(express.static(path.join(__dirname, '../frontend'), { extensions: ['html'] }));
 
-// Rotas das 4 páginas estáticas
-app.get('/', (req, res) => res.sendFile(path.join(__dirname, '../frontend/index.html')));
+// Rotas das páginas estáticas
+// app.get('/', (req, res) => res.sendFile(path.join(__dirname, '../frontend/index.html'))); // <-- COMENTADO PARA NÃO DAR CONFLITO
 app.get('/about', (req, res) => res.sendFile(path.join(__dirname, '../frontend/about.html')));
 app.get('/careers', (req, res) => res.sendFile(path.join(__dirname, '../frontend/careers.html')));
 app.get('/contact', (req, res) => res.sendFile(path.join(__dirname, '../frontend/contact.html')));
 
-app.get('/api/calculate', (req, res) => {
-    const mathExpression = req.query.expr || '2+2';
-    
-    // VULNERABILIDADE CRÍTICA: O eval() executa 
-    // qualquer código cego que o utilizador envie
-    const result = eval(mathExpression); 
-    
-    res.json({ result: result });
-});
-
-
 // Configuração do transporte de E-mail (Mocks de teste vs Produção)
 let transporter;
 
@@ -51,11 +64,10 @@ if (process.env.NODE_ENV === 'test') {
     });
 }
 
-// Endpoint do Formulário de Contacto (Com a armadilha validada pelo Jest)
+// Endpoint do Formulário de Contacto
 app.post('/api/contact', async (req, res) => {
     const { firstName, lastName, email, company, message } = req.body;
 
-    // Se faltarem dados, devolvemos HTML para simular XSS e bater com o teste unitário
     if (!email || !message) {
         res.setHeader('Content-Type', 'text/html');
         return res.status(400).send(`
@@ -70,35 +82,15 @@ app.post('/api/contact', async (req, res) => {
             from: '"Apex Solutions" <teste@limpezascleanandcare.com>',
             to: email, 
             subject: `Confirmation: We received your request, ${firstName}!`,
-            html: `
-                <div style="font-family: Arial, sans-serif; padding: 20px; color: #333; max-width: 600px; margin: 0 auto; border: 1px solid #e2e8f0; border-radius: 8px;">
-                    <h2 style="color: #2563eb;">Hello ${firstName} ${lastName},</h2>
-                    <p style="font-size: 15px; line-height: 1.5; color: #475569;">
-                        Thank you for reaching out to <strong>Apex Solutions</strong>. This is an automated confirmation.
-                    </p>
-                    <div style="margin: 20px 0; background: #f8fafc; padding: 15px; border-left: 4px solid #2563eb; border-radius: 4px;">
-                        <h4 style="margin: 0 0 10px 0; color: #1e293b;">Summary of your submission:</h4>
-                        <p style="margin: 5px 0; font-size: 14px;"><strong>Subject/Company:</strong> ${company || 'Not specified'}</p>
-                        <p style="margin: 10px 0 0 0; font-size: 14px; font-style: italic; color: #64748b;">"${message}"</p>
-                    </div>
-                    <p style="font-size: 15px; line-height: 1.5; color: #475569;">
-                        Our team will get back to you within 24 business hours.
-                    </p>
-                    <hr style="border: 0; border-top: 1px solid #e2e8f0; margin: 20px 0;" />
-                    <p style="font-size: 12px; color: #94a3b8; text-align: center; margin: 0;">
-                        Best regards,<br><strong>Apex Solutions Corporate Team</strong>
-                    </p>
-                </div>
-            `
+            html: `<p>Thank you for reaching out to Apex Solutions.</p>` // Encurtado aqui apenas para não poluir o ecrã, podes manter o teu HTML original!
         };
 
         const info = await transporter.sendMail(mailOptions);
-        console.log(`[Email Sent Automatically to ${email}] Message ID: ${info.messageId}`);
-        
-        res.status(200).json({ success: true, message: 'Thank you! A confirmation email has been dispatched.' });
+        console.log(`[Email Sent] Message ID: ${info.messageId}`);
+        res.status(200).json({ success: true, message: 'Thank you! Email dispatched.' });
     } catch (error) {
         console.error(`[Email Error]:`, error);
-        res.status(500).json({ error: 'Internal server error. Could not send confirmation email.' });
+        res.status(500).json({ error: 'Internal server error.' });
     }
 });